Skip to content

[CI/Build] Fix V1 LoRA failure #13767

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 24, 2025

No description provided.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee changed the title [Do not merge] Trying to fix V1 LORA failure [Do not merge] Trying to fix V1 LoRA failure Feb 24, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 24, 2025
Copy link

mergify bot commented Feb 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 24, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@mergify mergify bot removed the needs-rebase label Feb 25, 2025
@jeejeelee jeejeelee changed the title [Do not merge] Trying to fix V1 LoRA failure [CI/Build] Fix V1 LoRA failure Feb 25, 2025
@jeejeelee jeejeelee requested a review from khluu February 25, 2025 05:58
@jeejeelee
Copy link
Collaborator Author

Since #13775 has been reverted, we now only need to address the LoRA OOM problem in the main branch. @khluu

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@DarkLight1337
Copy link
Member

Unblocked V1 and LoRA tests, see if they pass.

@khluu
Copy link
Collaborator

khluu commented Feb 25, 2025

Unblocked V1 and LoRA tests, see if they pass.

Both are passing.. can we force merge? It's only waiting on AMD tests

@simon-mo simon-mo merged commit 37b6cb4 into vllm-project:main Feb 25, 2025
28 of 31 checks passed
@DarkLight1337
Copy link
Member

Done

Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants