Skip to content

[Misc][Chore] Clean Up AsyncOutputProcessing Logs #13780

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

robertgshaw2-redhat
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Feb 24, 2025

SUMMARY

  • This should not be a warning on V1
  • Remove warnings about lack of async output processing when disabled

Signed-off-by: rshaw@neuralmagic.com <rshaw@neuralmagic.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robertgshaw2-redhat I'd also noticed that but then forgot about it!

Should we still log these in the V0 case though?

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) February 24, 2025 20:29
@robertgshaw2-redhat
Copy link
Collaborator Author

robertgshaw2-redhat commented Feb 24, 2025

@njhill - I think that a warning is unnecessary.

It is disabled with:

  • --enforce-eager ... i.e. the user is already making a choice to not get best perf
  • platforms we do not support it on

@simon-mo simon-mo merged commit f61528d into main Feb 25, 2025
43 of 49 checks passed
@simon-mo simon-mo deleted the clean-up-async-output-proc-logs branch February 25, 2025 00:39
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants