Skip to content

Add comments on accessing kv_cache and attn_metadata #13887

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

Add comments on accessing kv_cache and attn_metadata #13887

merged 2 commits into from
Feb 26, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Feb 26, 2025

@hmellor
Add comments on accessing kv_cache and attn_metadata
0ab364c 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

youkaichao
youkaichao reviewed Feb 26, 2025
View reviewed changes
@hmellor
Mention where attn_metadata is set
1510d7f 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
youkaichao
youkaichao approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao youkaichao merged commit 0ecdd98 into vllm-project:main Feb 26, 2025
9 of 18 checks passed
@hmellor hmellor deleted the add-comment branch February 26, 2025 11:07
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@hmellor @Akshat-Tripathi
Add comments on accessing kv_cache and attn_metadata (vllm-projec…
b8fe8c1 
…t#13887)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Add comments on accessing kv_cache and attn_metadata (vllm-projec…
d7c29ff 
…t#13887)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmellor @youkaichao