Skip to content

[Hardware][TPU] Add check for no additional graph compilation during runtime #14710

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 21, 2025
Merged

[Hardware][TPU] Add check for no additional graph compilation during runtime #14710

merged 6 commits into from
Mar 21, 2025

Conversation

lsy323
Copy link
Collaborator

@lsy323 lsy323 commented Mar 12, 2025 •
edited by github-actions bot
Loading

Record the number of cached compilation graphs after warm up. After each execution step, check the number of cached compilation graphs is not changing.

  • Added env var VLLM_XLA_CHECK_RECOMPILATION with a default value of 0 to enable/disable the recompilation assertion
  • Refactored and enabled the assertion in CI.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 12, 2025
yaochengji
yaochengji suggested changes Mar 13, 2025
View reviewed changes
@lsy323 lsy323 marked this pull request as ready for review March 14, 2025 00:11
@mergify mergify bot added the ci/build label Mar 14, 2025
@lsy323 lsy323 requested a review from yaochengji March 14, 2025 00:13
yaochengji
yaochengji approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yaochengji yaochengji added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
NickLucche
NickLucche suggested changes Mar 15, 2025
View reviewed changes
@lsy323 lsy323 force-pushed the lsiyuan/add-compilation-assertion branch from da62779 to 63a6bd8 Compare March 17, 2025 22:37
@lsy323
Copy link
Collaborator Author

lsy323 commented Mar 17, 2025

Per offline discussion, use env var VLLM_XLA_CHECK_RECOMPILATION to control the check. The env var is default to False, and is enabled in CI.

@lsy323 lsy323 force-pushed the lsiyuan/add-compilation-assertion branch 2 times, most recently from 87b0e54 to 5c43c67 Compare March 19, 2025 05:00
NickLucche
NickLucche approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean thanks!

@lsy323 lsy323 force-pushed the lsiyuan/add-compilation-assertion branch from 0be5272 to 360003c Compare March 19, 2025 23:24
lsy323 added 5 commits March 19, 2025 23:55
@lsy323
add assertion for no additional compilation
a6b6973 
Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323
skip assertion for eagerg
234b7d7 
Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323
use env to control assertion
9f320e8 
Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323
enable check recompile env var in ci
fc180ab 
Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323
fix comment, check env var in ctor
fffb19c 
Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323
fix test
a5496de 
Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@lsy323 lsy323 force-pushed the lsiyuan/add-compilation-assertion branch from 360003c to a5496de Compare March 19, 2025 23:56
@lsy323 lsy323 changed the title [TPU] Add check for no additional graph compilation during runtime [Hardware][TPU] Add check for no additional graph compilation during runtime Mar 20, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 21, 2025 01:00
@robertgshaw2-redhat
Copy link
Collaborator

LGTM thanks!

@robertgshaw2-redhat robertgshaw2-redhat merged commit b15fd2b into vllm-project:main Mar 21, 2025
34 checks passed
@yaochengji yaochengji mentioned this pull request Mar 25, 2025
Closed
1 task
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@lsy323 @erictang000
[Hardware][TPU] Add check for no additional graph compilation during …
0b74734 
…runtime (vllm-project#14710)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
@lsy323
[Hardware][TPU] Add check for no additional graph compilation during …
1e47a06 
…runtime (vllm-project#14710)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@lsy323 @lulmer
[Hardware][TPU] Add check for no additional graph compilation during …
be65d39 
…runtime (vllm-project#14710)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@lsy323 @nishith-fujitsu
[Hardware][TPU] Add check for no additional graph compilation during …
b38ae54 
…runtime (vllm-project#14710)

Signed-off-by: Siyuan Liu <lsiyuan@google.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@yaochengji yaochengji yaochengji approved these changes

@youkaichao youkaichao youkaichao left review comments

@NickLucche NickLucche NickLucche approved these changes

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lsy323 @robertgshaw2-redhat @yaochengji @NickLucche @youkaichao