Skip to content

[Frontend] Add Phi-4-mini function calling support #14886

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 1, 2025
Merged

[Frontend] Add Phi-4-mini function calling support #14886

merged 13 commits into from
Apr 1, 2025

Conversation

kinfey
Copy link
Contributor

@kinfey kinfey commented Mar 16, 2025 •
edited by github-actions bot
Loading

Add Phi-4-mini function callong

FIX #14682 (#14682)

@kinfey
Add Phi-4-mini funciton calling
dfea61c 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Mar 16, 2025
kinfey added 4 commits March 16, 2025 22:14
@kinfey
Add Phi-4-mini funciton calling
e8e876b 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@kinfey
Add Phi-4-mini funciton calling
32ebf81 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@kinfey
Add Phi-4-mini funciton calling
5431d07 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@kinfey
Add Phi-4-mini funciton calling
d8302c1 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@DarkLight1337
Copy link
Member

cc @K-Mistele @mgoin

kinfey added 2 commits March 16, 2025 23:50
@kinfey
Add Phi-4-mini funciton calling
4885fd3 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@kinfey
Add Phi-4-mini funciton calling support
9cb52c3 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
@kinfey kinfey changed the title Add Phi-4-mini funciton calling Add Phi-4-mini funciton calling support Mar 16, 2025
@kinfey
Copy link
Contributor Author

kinfey commented Mar 17, 2025

@simon-mo @mgoin

@kangsan0420
Copy link

Does it compatible with phi-4?

@kinfey
Copy link
Contributor Author

kinfey commented Mar 18, 2025

@kangsan0420 Phi-4-mini and Phi-4-mm support function calling ,but Phi-4 not support

@kinfey
Copy link
Contributor Author

kinfey commented Mar 18, 2025

@DarkLight1337 Can you review this PR ？ Coz many people need

@DarkLight1337
Copy link
Member

Sorry, I'm not really qualified to review this. I have already tagged those who can review this PR.

@kinfey
Copy link
Contributor Author

kinfey commented Mar 18, 2025

Sorry, I'm not really qualified to review this. I have already tagged those who can review this PR.

thanks @mgoin @K-Mistele can you review

DarkLight1337
DarkLight1337 approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems they are busy. I'll just stamp this as the code looks reasonable, sorry for the delay!

@DarkLight1337 DarkLight1337 changed the title Add Phi-4-mini funciton calling support [Frontend] Add Phi-4-mini function calling support Mar 30, 2025
@mergify Mergify
Copy link

mergify bot commented Mar 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @kinfey.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 30, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 30, 2025 13:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 30, 2025
@mergify mergify bot removed the needs-rebase label Mar 30, 2025
@vllm-bot vllm-bot merged commit a164aea into vllm-project:main Apr 1, 2025
31 of 33 checks passed
@mgoin
Copy link
Member

mgoin commented Apr 1, 2025

Sorry for missing this, thank you for the contribution!

kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
@kinfey @DarkLight1337 @kylesayrs
[Frontend] Add Phi-4-mini function calling support (vllm-project#14886)
9c7dd92 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@kinfey @DarkLight1337 @Alex4210987
[Frontend] Add Phi-4-mini function calling support (vllm-project#14886)
21dab85 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@kinfey @DarkLight1337 @lulmer
[Frontend] Add Phi-4-mini function calling support (vllm-project#14886)
8a14237 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@kinfey @DarkLight1337 @nishith-fujitsu
[Frontend] Add Phi-4-mini function calling support (vllm-project#14886)
d788ecb 
Signed-off-by: Kinfey <kinfeylo@microsoft.com>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Phi-4-mini function calling support
5 participants
@kinfey @DarkLight1337 @kangsan0420 @mgoin @vllm-bot