Skip to content

[Bugfix] fix V1 Engine crash while handling requests with duplicate request id #15043

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2025
Merged

[Bugfix] fix V1 Engine crash while handling requests with duplicate request id #15043

merged 4 commits into from
Mar 20, 2025

Conversation

JasonJ2021
Copy link
Contributor

@JasonJ2021 JasonJ2021 commented Mar 18, 2025 •
edited by github-actions bot
Loading

FIX #15041

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 18, 2025
@njhill njhill self-assigned this Mar 18, 2025
@njhill
Copy link
Member

njhill commented Mar 18, 2025

Thanks @JasonJ2021! Actually that whole if statement is redundant anyhow and I am proposing to remove it in #14989.

@njhill
Copy link
Member

njhill commented Mar 18, 2025

@JasonJ2021 feel free to update this PR to remove that whole block. Thanks for adding the test too.

JasonJ2021 and others added 2 commits March 19, 2025 00:01
@JasonJ2021
[Bugfix] fix V1 Engine crash while handling requests with duplicate r…
6a6d84a 
…equest_id

Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
@JasonJ2021
remove redundant code
1db01a1 
Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
@JasonJ2021
Copy link
Contributor Author

@JasonJ2021 feel free to update this PR to remove that whole block. Thanks for adding the test too.

Done~

@DarkLight1337
Copy link
Member

Please fix the pre-commit failure

@JasonJ2021
fix pre-commit error
00b53b7 
Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
@JasonJ2021
Copy link
Contributor Author

Please fix the pre-commit failure

Sorry, it has been fixed.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2025
@njhill njhill added ready ONLY add when PR is ready to merge/full CI is needed and removed ready ONLY add when PR is ready to merge/full CI is needed labels Mar 19, 2025
@njhill
Copy link
Member

njhill commented Mar 19, 2025

@JasonJ2021 could you merge in the latest main branch? I'm unsure why the v1 tests are failing with OOM.

@JasonJ2021
Copy link
Contributor Author

@JasonJ2021 could you merge in the latest main branch? I'm unsure why the v1 tests are failing with OOM.

I have merged into the latest branch. But V1 tests still failed.

njhill
njhill approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasonJ2021!

@njhill njhill merged commit d8e82bc into vllm-project:main Mar 20, 2025
32 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@JasonJ2021 @erictang000
[Bugfix] fix V1 Engine crash while handling requests with duplicate r…
e7fd72e 
…equest id (vllm-project#15043)

Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Apr 1, 2025
@JasonJ2021 @gmarinho2
[Bugfix] fix V1 Engine crash while handling requests with duplicate r…
f1200b7 
…equest id (vllm-project#15043)

Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@JasonJ2021 @lulmer
[Bugfix] fix V1 Engine crash while handling requests with duplicate r…
4c2dd19 
…equest id (vllm-project#15043)

Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@JasonJ2021 @nishith-fujitsu
[Bugfix] fix V1 Engine crash while handling requests with duplicate r…
60dace9 
…equest id (vllm-project#15043)

Signed-off-by: Jiahui Sun <jhsun2020@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@njhill njhill njhill approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees

@njhill njhill

Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: V1 Engine crashes when sending requests with same request id
3 participants
@JasonJ2021 @njhill @DarkLight1337