Skip to content

[Model] Pixtral: Remove layer instantiation duplication #15053

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

[Model] Pixtral: Remove layer instantiation duplication #15053

merged 1 commit into from
Mar 19, 2025

Conversation

juliendenize
Copy link
Contributor

@juliendenize juliendenize commented Mar 18, 2025 •
edited by github-actions bot
Loading

Remove the duplication of layer instantiations for Pixtral.

@juliendenize
Remove layer instantiation duplication
368aa37 
Signed-off-by: Julien Denize <julien.denize@mistral.ai>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@juliendenize juliendenize changed the title [Model»Remove layer instantiation duplication [Model] Pixtral: Remove layer instantiation duplication Mar 18, 2025
patrickvonplaten
patrickvonplaten approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ywang96
ywang96 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 18, 2025
@DarkLight1337 DarkLight1337 merged commit 437f916 into vllm-project:main Mar 19, 2025
46 checks passed
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Apr 1, 2025
@juliendenize @gmarinho2
[Model] Pixtral: Remove layer instantiation duplication (vllm-project…
dc978f6 
…#15053)

Signed-off-by: Julien Denize <julien.denize@mistral.ai>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@juliendenize @lulmer
[Model] Pixtral: Remove layer instantiation duplication (vllm-project…
2d5fa3a 
…#15053)

Signed-off-by: Julien Denize <julien.denize@mistral.ai>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@juliendenize @nishith-fujitsu
[Model] Pixtral: Remove layer instantiation duplication (vllm-project…
f9a81b1 
…#15053)

Signed-off-by: Julien Denize <julien.denize@mistral.ai>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliendenize @patrickvonplaten @ywang96 @DarkLight1337