Skip to content

[V1] Minor V1 async engine test refactor #15075

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

[V1] Minor V1 async engine test refactor #15075

merged 2 commits into from
Mar 19, 2025

Conversation

andoorve
Copy link
Collaborator

Small clean up I missed last time.

@andoorve andoorve requested review from njhill and hmellor March 19, 2025 02:41
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@andoorve andoorve added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2025
@mergify Mergify
Copy link

mergify bot commented Mar 19, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @andoorve.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the v1 label Mar 19, 2025
@andoorve andoorve requested review from WoosukKwon and ywang96 March 19, 2025 02:41
@mergify mergify bot added the needs-rebase label Mar 19, 2025
Minor V1 async engine test refactor
813be88 
Signed-off-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
@andoorve andoorve force-pushed the async_v1_test_refac branch from d74ea8c to 813be88 Compare March 19, 2025 04:03
@mergify mergify bot removed the needs-rebase label Mar 19, 2025
hmellor
hmellor approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Once pre-commit is passing we can merge

Format
4bc0200 
Signed-off-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
@vllm-bot vllm-bot merged commit 61c7a1b into vllm-project:main Mar 19, 2025
12 of 14 checks passed
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Apr 1, 2025
@andoorve @gmarinho2
[V1] Minor V1 async engine test refactor (vllm-project#15075)
9d61296 
Signed-off-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
Co-authored-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@andoorve @lulmer
[V1] Minor V1 async engine test refactor (vllm-project#15075)
2cef566 
Signed-off-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
Co-authored-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@andoorve @nishith-fujitsu
[V1] Minor V1 async engine test refactor (vllm-project#15075)
5b88762 
Signed-off-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
Co-authored-by: andoorve <murali.andoorveedu@mail.utoronto.ca>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

@njhill njhill Awaiting requested review from njhill

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@ywang96 ywang96 Awaiting requested review from ywang96

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andoorve @hmellor @vllm-bot