Skip to content

[Misc] Clean up the BitsAndBytes arguments #15140

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

[Misc] Clean up the BitsAndBytes arguments #15140

merged 3 commits into from
Mar 21, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Mar 19, 2025 •
edited by github-actions bot
Loading

No description provided.

@jeejeelee
Init
7316a0d 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Modify doc
1f4011f 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee marked this pull request as draft March 19, 2025 16:01
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 19, 2025
@jeejeelee
Done
6085728 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee requested a review from Isotr0py March 20, 2025 06:15
@jeejeelee jeejeelee marked this pull request as ready for review March 20, 2025 06:16
@jeejeelee jeejeelee enabled auto-merge (squash) March 20, 2025 10:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2025
@vllm-bot vllm-bot merged commit 10f55fe into vllm-project:main Mar 21, 2025
44 of 46 checks passed
@jeejeelee jeejeelee deleted the clean-bnb-args branch March 21, 2025 02:38
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@jeejeelee @erictang000
[Misc] Clean up the BitsAndBytes arguments (vllm-project#15140)
5741cc5 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@jeejeelee @lulmer
[Misc] Clean up the BitsAndBytes arguments (vllm-project#15140)
8d53121 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@jeejeelee @nishith-fujitsu
[Misc] Clean up the BitsAndBytes arguments (vllm-project#15140)
08175f9 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation force-merge ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeejeelee @Isotr0py @vllm-bot