-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[V1][TPU] Change kv cache shape. #15145
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
[V1][TPU] Change kv cache shape. #15145
Conversation
Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Xiongfei!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vanbasten23 !
Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Xiongfei Wei <isaacwxf23@gmail.com>
This PR changes the kv cache shape from
[num_blocks, block_size, num_kv_heads, head_size]
to[num_blocks, block_size, num_kv_heads * head_size]
, in accordance with the ragged paged attention kernel change pytorch/xla#8851, in order to unblock the multi-chip scenario:key = key.view(num_tokens, self.num_kv_heads, self.head_size)
.Test plan:
cc @miladm @bythew3i