Skip to content

[Benchmark] Allow oversample request in benchmark dataset #15170

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2025

Conversation

JenZhao
Copy link
Contributor

@JenZhao JenZhao commented Mar 19, 2025

Enable oversample requests in HuggingFaceDataset, VisionArenaDataset and ShareGPTDataset.

This is mostly needed for small datasets like visionarena.

This branch

Dataset Backend Successful requests Benchmark duration (s) Total input tokens
hf-vision-arena openai-chat 10000 444.00 627745
hf openai-chat 10000 490.06 114223
sharegpt vllm 10000 262.65 2205227

Main branch

Dataset Backend Successful requests Benchmark duration (s) Total input tokens
hf-vision-arena openai-chat 500 36.29 33418
hf openai-chat 10000 413.91 114223
sharegpt vllm 10000 297.65 2205227
vllm serve Qwen/Qwen2-VL-7B-Instruct     --swap-space 16     --disable-log-requests
python3 vllm/benchmarks/benchmark_serving.py --model Qwen/Qwen2-VL-7B-Instruct --backend openai-chat --endpoint /v1/chat/completions --dataset-name hf --dataset-path lmarena-ai/vision-arena-bench-v0.1 --hf-split train --num-prompts 10000 --percentile-metrics ttft,tpot,e2el

python3 vllm/benchmarks/benchmark_serving.py --model Qwen/Qwen2-VL-7B-Instruct --backend openai-chat --endpoint /v1/chat/completions --dataset-name hf --dataset-path lmms-lab/LLaVA-OneVision-Data --hf-split train --hf-subset "chart2text(cauldron)" --num-prompts 10000 --percentile-metrics ttft,tpot,e2el

python3 vllm/benchmarks/benchmark_serving.py --backend vllm --model Qwen/Qwen2-VL-7B-Instruct --dataset-name sharegpt --dataset-path /home/jovyan/data/vllm_benchmark_datasets/ShareGPT_V3_unfiltered_cleaned_split.json --num-prompts 10000

JenZhao added 8 commits March 19, 2025 20:45
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@JenZhao JenZhao changed the title [Feature] Allow oversample request in benchmark dataset [Benchmark] Allow oversample request in benchmark dataset Mar 19, 2025
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
@JenZhao JenZhao marked this pull request as ready for review March 19, 2025 23:15
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - left a small naming nit

Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2025
@DarkLight1337 DarkLight1337 merged commit b88be22 into vllm-project:main Mar 20, 2025
21 of 23 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
…ct#15170)

Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Apr 1, 2025
…ct#15170)

Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…ct#15170)

Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
…ct#15170)

Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants