-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Benchmark] Allow oversample request in benchmark dataset #15170
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM - left a small naming nit
Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
…ct#15170) Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
…ct#15170) Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
…ct#15170) Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
…ct#15170) Signed-off-by: Jennifer Zhao <ai.jenniferzhao@gmail.com>
Enable oversample requests in HuggingFaceDataset, VisionArenaDataset and ShareGPTDataset.
This is mostly needed for small datasets like visionarena.
This branch
Main branch