[ci] feat: make the test_torchrun_example run with tp=2, external_dp=2 #15172
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Chi Zhang <zhangchi.usc1992@bytedance.com>
.buildkite/test-pipeline.yaml
Outdated
| @@ -493,6 +493,8 @@ steps: | |||
| - VLLM_MULTI_NODE=1 pytest -v -s distributed/test_pipeline_parallel.py | |||
| - # the following commands are for the second node, with ip 192.168.10.11 (ray environment already set up) | |||
| - VLLM_TEST_SAME_HOST=0 torchrun --nnodes 2 --nproc-per-node=2 --rdzv_backend=c10d --rdzv_endpoint=192.168.10.10 distributed/test_same_node.py | grep 'Same node test passed' | |||
| - VLLM_USE_V1=1 torchrun --nnodes 2 --nproc-per-node=2 --rdzv_backend=c10d --rdzv_endpoint=192.168.10.10 distributed/test_torchrun_example.py | |||
There was a problem hiding this comment.
this is 2 node test, you need to copy the command to run in different nodes.
you can put it in 4 GPUs tests.
vllm-project#15172) Signed-off-by: Chi Zhang <zhangchi.usc1992@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
vllm-project#15172) Signed-off-by: Chi Zhang <zhangchi.usc1992@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
vllm-project#15172) Signed-off-by: Chi Zhang <zhangchi.usc1992@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
vllm-project#15172) Signed-off-by: Chi Zhang <zhangchi.usc1992@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
This PR modifies the distributed/test_torchrun_example.py to run on two nodes with 4 GPUs, with tp=2, external_dp=2. This makes sure that the SPMD based runner will not break when there is a external dp (e.g., replica of vllm rollouts)