-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Bugfix] detect alibi and revert to FA2 #15231
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
a9b073c
to
d07cde3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catch, thanks for the contribution!
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Head branch was pushed to by a user without write access
d07cde3
to
c28b69f
Compare
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
On Hopper, Flash Attention 3 is enabled by default (since the v0.7.0 release), but FA3 does not support ALiBi positional encodings. This PR will revert to FA2 if alibi_slopes are passed in to
FlashAttentionBackend
.In the v0.8.1 release, the error when attempting to use a model with FA3 with ALiBi (such as bigscience/bloom-1b1) is:
Now there is change in vllm_flash_attn that will raise an AssertionError if alibi is used with FA3. This improves the error message, but the server would still fail to come up. With this PR, vLLM will fall back to FA2 instead of erroring.
FIX #13810