Skip to content

[ROCM] Upgrade torch to 2.6 #15244

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

SageMoore
Copy link
Contributor

@SageMoore SageMoore commented Mar 20, 2025

Now that we have the torch 2.6 upgrade finished, we can also move to torch 2.6 on ROCm. This PR just updates the torch version the requirements/rocm-build.txt

Here are the lm-eval results for 'meta-llama/Llama-3.1-8B-Instruct running with V1

|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value|   |Stderr|
|-----|------:|----------------|-----:|-----------|---|----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.794|±  |0.0181|
|     |       |strict-match    |     5|exact_match|↑  |0.774|±  |0.0187|

V0 Get's similar results

The unit testing situation is a bit complicated here. AFAIK the AMD CI runs with the docker container which is currently pinned to a 2.7 nightly. If there are any specific unit tests that would be good to run locally, please let me know.

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 20, 2025 19:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2025
@mergify mergify bot added the ci/build label Mar 20, 2025
@vllm-bot vllm-bot merged commit 2e0b4cf into vllm-project:main Mar 21, 2025
67 of 69 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
Signed-off-by: Sage Moore <sage@neuralmagic.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Sage Moore <sage@neuralmagic.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
Signed-off-by: Sage Moore <sage@neuralmagic.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants