Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the torch 2.6 upgrade finished, we can also move to torch 2.6 on ROCm. This PR just updates the torch version the
requirements/rocm-build.txt
Here are the lm-eval results for
'meta-llama/Llama-3.1-8B-Instruct
running with V1V0 Get's similar results
The unit testing situation is a bit complicated here. AFAIK the AMD CI runs with the docker container which is currently pinned to a 2.7 nightly. If there are any specific unit tests that would be good to run locally, please let me know.