Skip to content

[Misc] Remove redundant num_embeds #15443

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

[Misc] Remove redundant num_embeds #15443

merged 3 commits into from
Mar 25, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 25, 2025 •
edited by github-actions bot
Loading

Remove num_embeds from scatter_patch_features as it can be inferred from the shape of embeds_is_patch

Split out from #15438

@DarkLight1337
[Misc] Remove redundant num_embeds
8d4e0bd 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Update docs
30d79e5 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 25, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 25, 2025 06:18
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [Misc] Remove redundant num embeds [Misc] Remove redundant num_embeds Mar 25, 2025
@DarkLight1337 DarkLight1337 requested a review from ywang96 March 25, 2025 06:21
@DarkLight1337
Simplify
9808240 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@Isotr0py Isotr0py merged commit 5994430 into vllm-project:main Mar 25, 2025
37 checks passed
@DarkLight1337 DarkLight1337 deleted the no-num-embeds branch March 25, 2025 10:28
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@DarkLight1337 @erictang000
[Misc] Remove redundant num_embeds (vllm-project#15443)
c453d1e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@DarkLight1337 @wrmedford
[Misc] Remove redundant num_embeds (vllm-project#15443)
a70997b 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
@DarkLight1337 DarkLight1337 mentioned this pull request Mar 26, 2025
Merged
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
@DarkLight1337
[Misc] Remove redundant num_embeds (vllm-project#15443)
994118a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Misc] Remove redundant num_embeds (vllm-project#15443)
7f2be21 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@DarkLight1337 @nishith-fujitsu
[Misc] Remove redundant num_embeds (vllm-project#15443)
44154fd 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py