Skip to content

[TPU] support disabling xla compilation cache #15567

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

yaochengji
Copy link
Collaborator

The PyTorch/XLA compilation cache uses the Torch IR to generate keys. Consequently, changes in optimization flags, which affect compilation results, don't change the cache key. This can result in the wrong compilation being used. To prevent this, disabling the XLA compilation cache during development is recommended. We can disable it by export VLLM_XLA_CACHE_PATH=

Signed-off-by: Chengji Yao <chengjiyao@google.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 26, 2025
Copy link
Collaborator

@alexm-redhat alexm-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @yaochengji !

@alexm-redhat alexm-redhat enabled auto-merge (squash) March 26, 2025 19:29
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
@mgoin mgoin added the tpu Related to Google TPUs label Mar 26, 2025
@alexm-redhat alexm-redhat merged commit e74ff40 into vllm-project:main Mar 27, 2025
42 checks passed
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
Signed-off-by: Chengji Yao <chengjiyao@google.com>
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
Signed-off-by: Chengji Yao <chengjiyao@google.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: Chengji Yao <chengjiyao@google.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Chengji Yao <chengjiyao@google.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
Signed-off-by: Chengji Yao <chengjiyao@google.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants