Skip to content

Allow torchao quantization in SiglipMLP #15575

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Mar 26, 2025

Summary:
SiglipMLP is not quantized by default, so when we try to load a torchao quantized model it doesn't work because the mlps are not quantized, this PR enables quantization when we are loading a torchao quantized checkpoint.

Depends on #14231

Test Plan:
python benchmarks/benchmark_latency.py --input-len 256 --output-len 256 --model jerryzh168/gemma3-4b-it-float8dq --batch-size 1

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
SiglipMLP is not quantized by default, so when we try to load a torchao quantized model it doesn't work
because the mlps are not quantized, this PR enables quantization when we are loading a torchao quantized
checkpoint.

Depends on vllm-project#14231

Test Plan:
python benchmarks/benchmark_latency.py --input-len 256 --output-len 256 --model jerryzh168/gemma3-4b-it-float8dq --batch-size 1

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee
Copy link
Collaborator

Thanks, please address the CI failure.

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, we can merge first

@jeejeelee jeejeelee added ready ONLY add when PR is ready to merge/full CI is needed force-merge labels Mar 27, 2025
@vllm-bot vllm-bot merged commit dcf2a59 into vllm-project:main Mar 27, 2025
43 of 47 checks passed
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
force-merge ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants