-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Allow torchao quantization in SiglipMLP #15575
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
Summary: SiglipMLP is not quantized by default, so when we try to load a torchao quantized model it doesn't work because the mlps are not quantized, this PR enables quantization when we are loading a torchao quantized checkpoint. Depends on vllm-project#14231 Test Plan: python benchmarks/benchmark_latency.py --input-len 256 --output-len 256 --model jerryzh168/gemma3-4b-it-float8dq --batch-size 1 Reviewers: Subscribers: Tasks: Tags:
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Thanks, please address the CI failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, we can merge first
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Summary:
SiglipMLP is not quantized by default, so when we try to load a torchao quantized model it doesn't work because the mlps are not quantized, this PR enables quantization when we are loading a torchao quantized checkpoint.
Depends on #14231
Test Plan:
python benchmarks/benchmark_latency.py --input-len 256 --output-len 256 --model jerryzh168/gemma3-4b-it-float8dq --batch-size 1
Reviewers:
Subscribers:
Tasks:
Tags: