Skip to content

Recommend developing with Python 3.12 in developer guide #15811

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Recommend developing with Python 3.12 in developer guide #15811

merged 2 commits into from
Mar 31, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Mar 31, 2025

As requested in #15472 (comment)

@hmellor
Recommend developing with Python 3.12 in developer guide
16fe609 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor requested a review from DarkLight1337 March 31, 2025 10:51
@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 31, 2025
DarkLight1337
DarkLight1337 approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise LGTM

@hmellor @DarkLight1337
Update docs/source/contributing/overview.md
b535f9c 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
@hmellor hmellor enabled auto-merge (squash) March 31, 2025 11:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2025
@hmellor hmellor merged commit b932c04 into vllm-project:main Mar 31, 2025
17 of 19 checks passed
@hmellor hmellor deleted the doc-py-version branch March 31, 2025 11:54
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
@hmellor @DarkLight1337 @kylesayrs
Recommend developing with Python 3.12 in developer guide (vllm-projec…
92e4188 
…t#15811)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@hmellor @DarkLight1337 @Alex4210987
Recommend developing with Python 3.12 in developer guide (vllm-projec…
ad18274 
…t#15811)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @DarkLight1337 @lulmer
Recommend developing with Python 3.12 in developer guide (vllm-projec…
736a97c 
…t#15811)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@hmellor @DarkLight1337 @nishith-fujitsu
Recommend developing with Python 3.12 in developer guide (vllm-projec…
9eed3c6 
…t#15811)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmellor @DarkLight1337