Skip to content

[Misc] add description attribute in CLI #15921

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 2, 2025

add description with -h:

from:
$ vllm chat -h
INFO 04-02 11:12:24 [__init__.py:239] Automatically detected platform cpu.
usage: vllm chat [options]

options:
  --api-key API_KEY     API key for OpenAI services. If provided, this api key will overwrite the
                        api key obtained through environment variables. (default: None)

to:
$ vllm chat -h
INFO 04-02 11:13:23 [__init__.py:239] Automatically detected platform cpu.
usage: vllm chat [options]

Generate chat completions via the running API server.    <<--

options:
  --api-key API_KEY     API key for OpenAI services. If provided, this api key will overwrite the
                        api key obtained through environment variables. (default: None)

Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Apr 2, 2025
Signed-off-by: reidliu41 <reid201711@gmail.com>
@jeejeelee jeejeelee requested review from russellb and ywang96 April 2, 2025 07:55
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@russellb russellb enabled auto-merge (squash) April 7, 2025 20:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 7, 2025
@russellb russellb merged commit fad6e25 into vllm-project:main Apr 7, 2025
52 checks passed
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants