-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Bugfix] add hf_token to EngineArgs #16093
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch>
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch>
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch>
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch>
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch>
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
branched out a new source branch such that I am not blocked until @void-mckenzie gives his feedback |
QQ: Why not just use env variables like |
Hi @WoosukKwon , In the following DarkLight1337 and him agreed on the design that is implemented with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the OP of the original issue hasn't responded, I'll just merge this first
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch> Co-authored-by: paolovic <paul-philipp.luley@uzh.ch>
@paolovic Sorry! been busy with a few things. I see that this has been merged, let me try to see if I can pass the tokens. I'll keep you updated. once again, sorry for the delay! |
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch> Co-authored-by: paolovic <paul-philipp.luley@uzh.ch>
Signed-off-by: paolovic <paul-philipp.luley@uzh.ch> Co-authored-by: paolovic <paul-philipp.luley@uzh.ch> Signed-off-by: Yang Wang <elainewy@meta.com>
Added
hf_token
toEngineArgs
. It storesTrue
if just the flag and no value is given, it stores thevalue
if the flag and value are given, and evaluates toNone
otherwise.Also, it can be passed to
LLM
as an argument where it's forwarded in the__init__
toEngineArgs
where it's stored as an attribute and forwarded toModelConfig
increate_model_config
.Within
ModelConfig
it's available to be passed toget_hf_image_processor_config
which forwards it to transformers'get_image_processor_config
.FIX 14854