-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[VLM] Florence-2 supports online serving #16164
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can successfully run the model using the chat template and task token (which I have added to the PR description), thanks for working on this!
However it seems that |
I suggest updating the chat template to handle the task token externally. |
Signed-off-by: Isotr0py <2037008807@qq.com>
Oh, it's just because |
Can confirm, this should be good to go then |
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py nice, thanks a lot! Just a quick question, I've being trying to use the tasks from Florence that are suppose to return the position from the objects (OD, OCR_WITH_REGION, etc) and I'm getting an empty response, or just the object names but no box positions. Description tasks work fine. This is how I'm using it:
With the following cURL to test it:
An the response: Is there anything I'm missing or doing it wrong? |
@PedroMiolaSilva Can you try to use this tokenizer(Isotr0py/Florence-2-tokenizer) and add |
@Isotr0py it worked, thanks a lot! For this model, shouldn't the default value for skip_special_tokens be set to True? |
No, because Florence-2 uses special tokens like |
I'm sorry, I mean set to False, because by default it is set to true right? |
Yes. It's set to |
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Yang Wang <elainewy@meta.com>
Example command to launch the server:
Inference:
FIX #15968