Skip to content

[Misc] Add warning for multimodal data in LLM.beam_search #16241

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

[Misc] Add warning for multimodal data in LLM.beam_search #16241

merged 1 commit into from
Apr 8, 2025

Conversation

alex-jw-brooks
Copy link
Contributor

@alex-jw-brooks alex-jw-brooks commented Apr 8, 2025 •
edited by github-actions bot
Loading

#9427 fixed passing multimodal data through the async version version of beam search, but it's currently being dropped in LLM.beam_search. For now, this adds a warning if MM data is passed since it won't be properly processed.

More details here #15694 #16240

@alex-jw-brooks
Add warning for mm data in llm.beam_search
42d6dde 
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Apr 8, 2025
DarkLight1337
DarkLight1337 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to fix this in another PR?

@alex-jw-brooks
Copy link
Contributor Author

alex-jw-brooks commented Apr 8, 2025 •
edited
Loading

@DarkLight1337 thanks for the fast review! Yeah, I can definitely take a pass at fixing it

@alex-jw-brooks alex-jw-brooks changed the title Add warning for multimodal data in LLM.beam_search [Misc] Add warning for multimodal data in LLM.beam_search Apr 8, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 8, 2025 08:42
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@vllm-bot vllm-bot merged commit 69ecaa7 into vllm-project:main Apr 8, 2025
58 of 63 checks passed
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@alex-jw-brooks @nishith-fujitsu
[Misc] Add warning for multimodal data in LLM.beam_search (vllm-proje…
b6b6f60 
…ct#16241)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@alex-jw-brooks @yangw-dev
[Misc] Add warning for multimodal data in LLM.beam_search (vllm-proje…
703cccb 
…ct#16241)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-jw-brooks @DarkLight1337 @vllm-bot