[Bugfix]if the content is started with ":"(response of ping), client should i…

[sywangyi]

…gnore it.

FILL IN THE PR DESCRIPTION HERE

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

---

PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

• [Bugfix] for bug fixes.
• [CI/Build] for build or continuous integration improvements.
• [Doc] for documentation fixes and improvements.
• [Model] for adding a new model or improving an existing model. Model name should appear in the title.
• [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
• [Kernel] for changes affecting CUDA kernels or other compute kernels.
• [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
• [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
• [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

• We adhere to Google Python style guide and Google C++ style guide.
• Pass all linter checks. Please use format.sh to format your code.
• The code need to be well-documented to ensure future contributors can easily understand the code.
• Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
• Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

• After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
• After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
• After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
• Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

[sywangyi]

found TGI benchmark "Successful requests" < "request send". it's not because the request is not correctly handled. it's caused by the client mishandling of ":" (ping response)
similar fix in chatchat-space/Langchain-Chatchat#2585

[ywang96]

Hey @sywangyi thanks for the fix - Is this an issue specific to TGI? Was there a recent change in TGI that caused this?
I have used this script fairly frequently but never ran into this, so I wonder what the root cause is.

[sywangyi]

I use following command to test TGI
numactl -m 0 -C 0-55 python3 benchmark_serving.py --backend tgi --model meta-llama/Llama-2-7b-chat-hf --dataset-name sharegpt --dataset-path ShareGPT_V3_unfiltered_cleaned_split.json --request-rate inf --num-prompts 80 --endpoint /generate_stream --host 0.0.0.0 --port 8080
I use Xeon as TGI backend, but similar issue is found in A100

without this PR.
result is like
============ Serving Benchmark Result ============
Successful requests: 57
Benchmark duration (s): 137.55
with the PR
result is like
============ Serving Benchmark Result ============
Successful requests: 80
Benchmark duration (s): 151.67

[sywangyi]

and This is my first time to use VLLM tool to benchmark TGI. not sure if it's specific to TGI

[ywang96]

I'm ok with merging this change, but I was just wondering if we needed to add this fix to all backend request functions.

@KuntaiDu Since you have run this script recently, have you run into any issue like this one? Thanks!

[MingxuZh]

I've found that this PR is also effective in helping to avoid lost requests when testing TGI with A100.

[ywang96]

Since this is happening on others as well, I'm going to approve this. Thanks for the fix!