Skip to content

[Bugfix] Fix LoRA with PP #7292

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

[Bugfix] Fix LoRA with PP #7292

merged 1 commit into from
Aug 8, 2024

Conversation

andoorve
Copy link
Collaborator

@andoorve andoorve commented Aug 8, 2024

FIX #7253

@andoorve andoorve marked this pull request as ready for review August 8, 2024 06:20
@andoorve
Copy link
Collaborator Author

andoorve commented Aug 8, 2024

@youkaichao

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@andoorve andoorve mentioned this pull request Aug 8, 2024
Closed
youkaichao
youkaichao approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@youkaichao youkaichao merged commit 6dffa4b into vllm-project:main Aug 8, 2024
18 checks passed
@andoorve andoorve deleted the lora-pp branch October 8, 2024 22:46
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@andoorve @Alvant
[Bugfix] Fix LoRA with PP (vllm-project#7292)
30d9b51 
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@andoorve @LeiWang1999
[Bugfix] Fix LoRA with PP (vllm-project#7292)
b2e2813 
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Lora is incompatible with distributed pipeline parallelism
2 participants
@andoorve @youkaichao