Skip to content

[BugFix] Fix Duplicate Assignment of Class Variable in Hermes2ProToolParser #8423

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

[BugFix] Fix Duplicate Assignment of Class Variable in Hermes2ProToolParser #8423

merged 1 commit into from
Sep 12, 2024

Conversation

vegaluisjose
Copy link
Contributor

Fix Duplicate Assignment of Class Variable in Hermes2ProToolParser

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 12, 2024 16:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 12, 2024
@youkaichao youkaichao disabled auto-merge September 12, 2024 18:09
@youkaichao youkaichao merged commit 1f0c75a into vllm-project:main Sep 12, 2024
59 of 69 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@vegaluisjose @Alvant
[BugFix] Fix Duplicate Assignment in Hermes2ProToolParser (vllm-proje…
bcacf30 
…ct#8423)

Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@vegaluisjose @LeiWang1999
[BugFix] Fix Duplicate Assignment in Hermes2ProToolParser (vllm-proje…
f7af25f 
…ct#8423)

Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vegaluisjose @mgoin @DarkLight1337 @youkaichao