Skip to content

[CI/Build] Update pixtral tests to use JSON #8436

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[CI/Build] Update pixtral tests to use JSON #8436

merged 2 commits into from
Sep 13, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Sep 13, 2024

I can verify that the Pixtral tests after #8415 pass on my L40. However having pickle files in the repo may be flagged as a security risk, so I'm changing them to JSON in this PR.

cc @patrickvonplaten

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Comment on lines +145 to +148
check_logprobs_close(outputs_0_lst=EXPECTED_CHAT_LOGPROBS,
outputs_1_lst=logprobs,
name_0="h100_ref",
name_1="output")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swapped the order here so that it matches the other tests where expected output is in index 0 and actual output in index 1.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 13, 2024
@ywang96
Copy link
Member

ywang96 commented Sep 13, 2024

Do you want to remove the skip decorator and see if it actually passes on our CI?

@DarkLight1337
Copy link
Member Author

Even the smallest test takes up 40 GB VRAM so it will cause OOM in CI.

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Sep 13, 2024

We probably have to split the model using TP if we want to run the tests in CI.

@ywang96
Copy link
Member

ywang96 commented Sep 13, 2024

Let’s skip the TP addition for a later PR then

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 13, 2024 02:00
@DarkLight1337 DarkLight1337 merged commit 8427550 into vllm-project:main Sep 13, 2024
36 checks passed
@DarkLight1337 DarkLight1337 deleted the update-pixtral-tests branch September 13, 2024 03:50
@patrickvonplaten
Copy link
Contributor

Thanks a lot @DarkLight1337 - make sense pickle is not the best format

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants