-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[CI/Build] Update pixtral tests to use JSON #8436
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
[CI/Build] Update pixtral tests to use JSON #8436
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
check_logprobs_close(outputs_0_lst=EXPECTED_CHAT_LOGPROBS, | ||
outputs_1_lst=logprobs, | ||
name_0="h100_ref", | ||
name_1="output") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swapped the order here so that it matches the other tests where expected output is in index 0 and actual output in index 1.
Do you want to remove the skip decorator and see if it actually passes on our CI? |
Even the smallest test takes up 40 GB VRAM so it will cause OOM in CI. |
We probably have to split the model using TP if we want to run the tests in CI. |
Let’s skip the TP addition for a later PR then |
Thanks a lot @DarkLight1337 - make sense pickle is not the best format |
Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
I can verify that the Pixtral tests after #8415 pass on my L40. However having pickle files in the repo may be flagged as a security risk, so I'm changing them to JSON in this PR.
cc @patrickvonplaten