Skip to content

chore: add pnpm setting to pnpm-workspace #13268

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

btea
Copy link
Contributor

@btea btea commented May 2, 2025

To ease management and avoid conflicts with npm, pnpm supports moving all configurations to the pnpm-workspace.yaml file. For more github.com/orgs/pnpm/discussions/9037

Summary by CodeRabbit

  • Chores
    • Updated workspace configuration to adjust dependency handling and version constraints. No impact on application features or functionality.

Copy link

coderabbitai bot commented May 2, 2025

Walkthrough

The changes involve moving pnpm-specific configuration settings from the package.json file to the pnpm-workspace.yaml file. The removed configuration includes peer dependency rules for certain TypeScript ESLint packages and a list of dependencies to be treated as only built dependencies. These settings are now present in the workspace YAML file, maintaining the same constraints and dependency handling at the workspace level.

Changes

File(s) Change Summary
package.json Removed the entire "pnpm" configuration section, including peerDependencyRules and onlyBuiltDependencies.
pnpm-workspace.yaml Added onlyBuiltDependencies and peerDependencyRules sections, mirroring the removed configuration from package.json.

Poem

A hop from JSON to YAML land,
Configs in the workspace, tidy and grand.
Peer rules and builds, now neatly aligned,
In one cozy file, dependencies combined.
With every leap, our code feels right—
A rabbit's delight in the soft moonlight!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented May 2, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.2 kB 34.4 kB
vue.global.prod.js 159 kB 58.4 kB 51.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.6 kB
createApp 54.5 kB 21.2 kB 19.4 kB
createSSRApp 58.7 kB 22.9 kB 20.9 kB
defineCustomElement 59.3 kB 22.8 kB 20.8 kB
overall 68.6 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented May 2, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13268

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13268

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13268

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13268

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13268

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13268

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13268

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13268

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13268

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13268

vue

npm i https://pkg.pr.new/vue@13268

commit: 09401ea

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b23fd2 and 09401ea.

📒 Files selected for processing (2)
  • package.json (0 hunks)
  • pnpm-workspace.yaml (1 hunks)
💤 Files with no reviewable changes (1)
  • package.json
🔇 Additional comments (1)
pnpm-workspace.yaml (1)

14-20: Relocate onlyBuiltDependencies to workspace config – looks good

The onlyBuiltDependencies section has been correctly moved into the workspace YAML and follows the expected syntax.

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. labels May 3, 2025
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants