Skip to content

Feature Request: Slim (Template) support #141

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
gencer opened this issue Jul 26, 2018 · 5 comments · May be fixed by #300
Open

Feature Request: Slim (Template) support #141

gencer opened this issue Jul 26, 2018 · 5 comments · May be fixed by #300

Comments

@gencer
Copy link

gencer commented Jul 26, 2018

Slim is a Ruby HTML Template engine alternative to Haml and ERB.

It would be nice to see slim template engine support with this outstanding extension.

In slim, we use tabbed syntax and everything starts with . (dot) is a class. Everything starts with # (hash) is an ID.

Whenever we hit dot on keyboard, this plugin can start to show us possible class names.

Note: dots in strings ''/"" or followed by | does not count.

Sample:

.my-sass-class-1.another-class
	a#link-1.this-is-a-class class="we-also-have-this-too"
		| Hello.
#my-id.class

Reference: https://github.com/slim-template/slim

@gencer
Copy link
Author

gencer commented Jul 26, 2018

I will go with my drop-in replacement for this. See here

Reason I did not send Pull request was;

  1. I need it urgently on few environments. So local deploy is not something I want. I needed this extension install-able through marketplace.
  2. I've manually processed SCSS instead of how did you do in CSS. I thought you might reject and not like that. (again I did in need of urgent solution.)

If you are comply with my reasons, I can un-publish it, send you the pull request and go with your way. Until then I would like to keep my extension as it is.

@muuvmuuv
Copy link

muuvmuuv commented Aug 8, 2018

You can use "html-css-class-completion.includeGlobPattern": "**/*.{css,html,scss}", to add other extensions.

@gencer
Copy link
Author

gencer commented Aug 8, 2018

@muuvmuuv, Of course that was the first thing I tried. This won't solve classes in a class, and magic class functions. My implementation just does it very well. Also, Slim support was a number one priority for me -which I solved it too-.

@muuvmuuv
Copy link

muuvmuuv commented Aug 8, 2018

Ah, I understand, but why did you not simply created a fork and pull request for your feature? That would reduce duplicate plugins with the same functionality in the VSCode Marketplace?

Please ask the author about to merge with you extension :)

@muuvmuuv
Copy link

muuvmuuv commented Aug 8, 2018

Ah sorry did not read your second comment. Anyway, I hope the author will be fine or you both find a way to make this plugin more scalable for future templates.

dkniffin added a commit to dkniffin/HTML-CSS-Class-Completion that referenced this issue Feb 19, 2021
@dkniffin dkniffin linked a pull request Feb 19, 2021 that will close this issue
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants