Skip to content

Fix for eldoc-mode for ClojureCLR #164

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged

Conversation

dotemacs
Copy link
Contributor

@dotemacs dotemacs commented May 31, 2019

When using the REPL, whenever you'd type the function name, because
Throwable is JVM specific, eldoc-mode would try to look up the
function and when it wouldn't find it, it would bomb out with the
complaint that Throwable wasn't defined. Which is to be expected since
it's not running on JVM.

Looking at the documentation
https://docs.oracle.com/javase/10/docs/api/java/lang/Throwable.html

The Throwable class is the superclass of all errors and exceptions in the Java language.

And in C#, Exception
https://docs.microsoft.com/en-us/dotnet/api/system.exception?redirectedfrom=MSDN&view=netframework-4.8

This class is the base class for all exceptions.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

When using the REPL, whenever you'd type the function name, because
Throwable is JVM specific, eldoc-mode would try to look up the
function and when it wouldn't find it, it would bomb out with the
complaint that Throwable wasn't defined. Which is to be expected since
it's not running on JVM.

Looking at the documentation
https://docs.oracle.com/javase/10/docs/api/java/lang/Throwable.html

"The Throwable class is the superclass of all errors and exceptions in
the Java language."

And in C#, Exception
https://docs.microsoft.com/en-us/dotnet/api/system.exception?redirectedfrom=MSDN&view=netframework-4.8

"This class is the base class for all exceptions."
@dotemacs dotemacs force-pushed the clojureclr-eldoc-mode-support branch from a641353 to 7224e6e Compare May 31, 2019 10:48
@bbatsov bbatsov merged commit 0fc2350 into clojure-emacs:master May 31, 2019
@bbatsov
Copy link
Member

bbatsov commented May 31, 2019

Nice! Thanks for fixing this. I never thought that inf-clojure might be a good option for ClojureCLR users.

@dotemacs dotemacs deleted the clojureclr-eldoc-mode-support branch May 31, 2019 15:36
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants