Remove reader conditional from Clojure repl type arglists default config #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing configuration causes Clojure repls to fail with
java.lang.RuntimeException: Conditional read not allowed
as soon as arglists are requested.I ran into this while using an embedded nrepl configured with transport/tty, here's a dummy project you can use to try it out.
It's not clear to me if this is sacrificing functionality that nrepl transport/tty doesn't implement or if it never worked.
Thanks for inf-clojure!
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdoc
warningsThanks!