Fix for #79 #82

arichiardi · 2017-06-06T05:38:35Z

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

The commits are consistent with our contribution guidelines
The new code is not generating bytecode or M-x checkdoc warnings
You've updated the changelog (if adding/changing user-visible functionality)
You've updated the readme (if adding/changing user-visible functionality)

Thanks!

bbatsov · 2017-06-06T06:13:12Z

README.md

@@ -99,6 +99,26 @@ point. You can, however, change this behaviour by invoking such
 commands with a prefix argument. For instance: `C-u C-c C-v` will ask
 for the symbol you want to show the docstring for.

+#### *WARNING* - Standard REPLs


I think the title of this section is extremely misleading.

Suggestions?

Probably this should be in some caveats or faq section of the readme.

Or in configuration.

bbatsov · 2017-06-06T06:13:42Z

README.md

+
+Note that if you decide _NOT_ to use the socket repl, it is highly recommended
+you disable output coloring and/or readline facilities: `inf-clojure` does not
+filter out ASCII escape characters at the moment and will not behave correctly.


Why filter them out? Why not simply apply them the same way we do in CIDER? It's quite trivial.

We apply them visually, but the regex match is failing every time because of those. A solution is for our regexes to skip the ascii escape codes. Do you have a link for cider? If there is an alternative I am all for it.

The issue of speaking with the terminal is a big one. Comint hides some of the complexity but cannot eliminate it. Things like embedded readline and colors all change behaviors and I am so far from being an expert that I was even wondering whether console support should be dropped completely at some point (maybe by adopting another Emacs socket-only package). Sooner or later...

...I guess it will happen. Cider does not handle this because of nRepl in between. In any case I can try to escape them, I saw it in some other plugin ...We'll see about the result.

hlolli · 2017-06-06T17:21:27Z

Checked out this pull requests and this is what I'm getting

WARNING: No such namespace: complete.core, could not locate complete/core.cljs, complete/core.cljc, or Closure namespace "" at line 1 
             ⬆
WARNING: Use of undeclared Var complete.core/completions at line 1 
complete is not defined
	 (evalmachine.<anonymous>:1:1)
	 ContextifyScript.Script.runInThisContext (vm.cljs:44:33)
	 Object.runInThisContext (vm.cljs:116:38)
	 (Object.lumoEval)
	 lumo.repl.caching_node_eval (NO_SOURCE_FILE <embedded>:6133:194)
	 (NO_SOURCE_FILE <embedded>:5372:29)
	 x (NO_SOURCE_FILE <embedded>:5373:13)
	 Object.cljs.js.eval_str_STAR_ (NO_SOURCE_FILE <embedded>:5374:28)
	 Function.cljs.js.eval_str.cljs$core$IFn$_invoke$arity$5 (NO_SOURCE_FILE <embedded>:5377:508)
	 Object.lumo.repl.execute_text (NO_SOURCE_FILE <embedded>:6257:240)

and as I type reduce (which I fixed in my pull request)

Company: backend company-capf error "Wrong type argument: listp, ⬆" with args (candidates reduc)
Company: An error occurred in auto-begin
Company: backend company-capf error "Wrong type argument: listp, ⬆" with args (candidates reduce)

arichiardi · 2017-06-06T17:30:44Z

Is this on Lumo? It means it recognizes it as Clojure Repl. Thanks for testing, very helpful. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

hlolli · 2017-06-06T17:48:02Z

On lumo yes (can be confirmed by looking at the stacktrace).

No problem!

arichiardi · 2017-06-08T18:47:28Z

@hlolli how do you launch lumo? Because it does not happen here, I can see the eldoc. Lumo should be launched with -d because inf-clojure does not yet parses out readline and/or color escapes.

hlolli · 2017-06-08T20:09:02Z

I did it like this

(defun lumo-start ()
  (interactive)
  (inf-clojure "cljs-boot lumo -K -d") 
  (with-current-buffer (buffer-name)
    (split-window-sensibly) 
    (previous-window)
    (previous-buffer)))

arichiardi · 2017-06-08T20:49:30Z

@hlolli sorry about that, just double checking 😄 I can reproduce.

arichiardi · 2017-06-08T21:19:14Z

You error above still happens when the first thing you do is (redu at a lumo REPL.

arichiardi · 2017-06-14T23:47:20Z

@hlolli the code above should solve things. It would be great if you can apply #81 on top and check. I did that, and I see no errors in both lumo and normal repls.

hlolli · 2017-06-15T17:22:42Z

My changes for #81 are in your pull-request #82, so as expected, completions are working.

Eldoc is not on the other hand, just empty minibuffer.

But these three open pull-requests are now a soup.

arichiardi · 2017-06-15T17:40:45Z

Oh ok I thought I took it off from mine, sorry about that! I guess @bbatsov can merge #81, than I can rebase on top of it.

arichiardi · 2017-06-30T21:00:34Z

The eldoc error in Lumo is related to a pr-str added somehow to the command (fixed in #84). Just discovered. I have a better patch for this, just need time to polish it up.

arichiardi · 2017-07-02T23:09:53Z

Split this one in two (or more) while discovering and solving issues.

arichiardi · 2017-07-03T05:43:13Z

@bbatsov so we are not merging this one? Why?

bbatsov · 2017-07-03T05:44:49Z

My bad. Misinterpreted the comment.

arichiardi · 2017-07-03T07:06:05Z

Ok cool lemme know 😀

arichiardi changed the title ~~Fix 79~~ Fix for #79 Jun 6, 2017

arichiardi force-pushed the fix-79 branch 3 times, most recently from 55bac77 to 18a4c0f Compare June 6, 2017 05:42

bbatsov reviewed Jun 6, 2017

View reviewed changes

arichiardi mentioned this pull request Jun 6, 2017

make case when nil is a string #80

Closed

2 tasks

arichiardi force-pushed the fix-79 branch from 2e1a69e to 5d55f30 Compare June 14, 2017 23:45

arichiardi changed the title ~~Fix for #79~~ Fix for #79 and #83 Jun 14, 2017

arichiardi force-pushed the fix-79 branch 2 times, most recently from ee72d95 to a152514 Compare July 2, 2017 21:46

arichiardi changed the title ~~Fix for #79 and #83~~ Fix for #79 Jul 2, 2017

arichiardi added 3 commits July 2, 2017 16:08

Disable coloring for the boot repl

8c2a0ef

Add Caveats section to README

f519564

Update CHANGELOG

0d41d3b

arichiardi force-pushed the fix-79 branch from a152514 to 0d41d3b Compare July 2, 2017 23:09

bbatsov closed this Jul 3, 2017

bbatsov reopened this Jul 3, 2017

Merge branch 'master' into fix-79

29538ca

bbatsov merged commit f666f60 into clojure-emacs:master Jul 6, 2017

arichiardi deleted the fix-79 branch July 6, 2017 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for #79 #82

Fix for #79 #82

arichiardi commented Jun 6, 2017 •

edited

Loading

bbatsov Jun 6, 2017

arichiardi Jun 6, 2017

bbatsov Jun 15, 2017

bbatsov Jun 15, 2017

bbatsov Jun 6, 2017

arichiardi Jun 6, 2017

arichiardi Jun 15, 2017

arichiardi Jun 15, 2017

hlolli commented Jun 6, 2017

arichiardi commented Jun 6, 2017 via email

hlolli commented Jun 6, 2017

arichiardi commented Jun 8, 2017

hlolli commented Jun 8, 2017

arichiardi commented Jun 8, 2017 •

edited

Loading

arichiardi commented Jun 8, 2017

arichiardi commented Jun 14, 2017

hlolli commented Jun 15, 2017

arichiardi commented Jun 15, 2017

arichiardi commented Jun 30, 2017 •

edited

Loading

arichiardi commented Jul 2, 2017

arichiardi commented Jul 3, 2017

bbatsov commented Jul 3, 2017

arichiardi commented Jul 3, 2017

Fix for #79 #82

Fix for #79 #82

Conversation

arichiardi commented Jun 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hlolli commented Jun 6, 2017

arichiardi commented Jun 6, 2017 via email

hlolli commented Jun 6, 2017

arichiardi commented Jun 8, 2017

hlolli commented Jun 8, 2017

arichiardi commented Jun 8, 2017 • edited Loading

arichiardi commented Jun 8, 2017

arichiardi commented Jun 14, 2017

hlolli commented Jun 15, 2017

arichiardi commented Jun 15, 2017

arichiardi commented Jun 30, 2017 • edited Loading

arichiardi commented Jul 2, 2017

arichiardi commented Jul 3, 2017

bbatsov commented Jul 3, 2017

arichiardi commented Jul 3, 2017

arichiardi commented Jun 6, 2017 •

edited

Loading

arichiardi commented Jun 8, 2017 •

edited

Loading

arichiardi commented Jun 30, 2017 •

edited

Loading