Disable pretty print when fetching lumo arglists #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 3, 2017
inf-clojure.el
Outdated
| @@ -703,7 +703,7 @@ If you are using REPL types, it will pickup the most approapriate | |||
| (define-obsolete-variable-alias 'inf-clojure-arglist-command 'inf-clojure-arglists-form "2.0.0") | |||
|
|
|||
| (defcustom inf-clojure-arglists-form-lumo | |||
| "(pr-str (lumo.repl/get-arglists \"%s\"))" | |||
| "(do (set! lumo.repl/*pprint-results* false) (lumo.repl/get-arglists \"%s\"))" | |||
There was a problem hiding this comment.
Why set this every time? I'd simply let-bind it around the other form.
There was a problem hiding this comment.
Let bind does not work in cljs bootstrap. Still I guess I could do it once. There is a problem though...it is global so I might actually need to rethink this solution.
|
Cannot think about a better solution. The only one would be to post process the output and make it single-lined after the evaluation. We alrerdy have all the pieces in place, just need to hook the post process function. |
arichiardi
force-pushed
the
fix-lumo-eldoc
branch
from
9ab6680 to
cab944a
Compare
It hacks like a hack.
arichiardi
force-pushed
the
fix-lumo-eldoc
branch
from
cab944a to
1285206
Compare
|
Found a hack for this, works fine and does avoid changing the value. |
|
Looks pretty ugly, but I guess that's the best we can do for now. |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lumo has pretty print by default enabled. So this fix is necessary in order to avoid seeing newlines in eldoc.