Skip to content

refactor: simplify handling of reused event sources #1518

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 5, 2022
Merged

refactor: simplify handling of reused event sources #1518

merged 6 commits into from
Oct 5, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Oct 4, 2022

No description provided.

@csviri csviri self-assigned this Oct 4, 2022
@csviri csviri changed the base branch from main to next October 4, 2022 09:02
@csviri csviri requested a review from metacosm October 4, 2022 09:02
@csviri csviri changed the title Use es instead do not provide feat: dependnet resource api refine: "use event source" instead of "do not provide" Oct 4, 2022
@metacosm metacosm changed the title feat: dependnet resource api refine: "use event source" instead of "do not provide" refactor: simplify EventSource reuse configuration Oct 4, 2022
@metacosm metacosm force-pushed the use-es-instead-do-not-provide branch from 705e9a5 to 22e7d92 Compare October 4, 2022 15:05
@metacosm metacosm mentioned this pull request Oct 4, 2022
Closed
@metacosm metacosm changed the title refactor: simplify EventSource reuse configuration refactor: simplify handling of reused event sources Oct 4, 2022
csviri
csviri commented Oct 5, 2022
View reviewed changes
...n/java/io/javaoperatorsdk/operator/api/reconciler/dependent/DeferrableEventSourceHolder.java Outdated

default void useEventSourceWithName(String name) {}

Optional<String> resolveEventSource(EventSourceRetriever<P> eventSourceRetriever);
Copy link
Collaborator Author

@csviri csviri Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Optional part feels a little weird to me. IMO should rather throw something like EventSourceNotFoundException.
What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not have to be even collected, since this will always fail to start the operator, and needs code change. So it is not even a config error if an exception is thrown here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a little awkward. I'd like to collect it because, as a user, I prefer to know all the mistakes I made at once if possible instead of failing, fixing one thing only to have an error on another thing and fail again…

@csviri csviri merged commit f3ec6db into next Oct 5, 2022
@csviri csviri deleted the use-es-instead-do-not-provide branch October 5, 2022 08:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

csviri added a commit that referenced this pull request Oct 6, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
a0e06c3 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Oct 6, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
d8da98b 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
metacosm added a commit that referenced this pull request Oct 7, 2022
@csviri @metacosm
refactor: improve bulk dependent resource api (#1525)
7442012 
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <metacosm@gmail.com>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <metacosm@gmail.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri added a commit that referenced this pull request Oct 19, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
1aee7c7 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Oct 19, 2022
@csviri @metacosm
refactor: improve bulk dependent resource api (#1525)
e0776a4 
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <metacosm@gmail.com>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <metacosm@gmail.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri added a commit that referenced this pull request Oct 21, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
a80b367 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Oct 21, 2022
@csviri @metacosm
refactor: improve bulk dependent resource api (#1525)
30d084e 
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <metacosm@gmail.com>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <metacosm@gmail.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri added a commit that referenced this pull request Oct 25, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
031e86c 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Oct 25, 2022
@csviri @metacosm
refactor: improve bulk dependent resource api (#1525)
3574655 
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <metacosm@gmail.com>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <metacosm@gmail.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri added a commit that referenced this pull request Oct 28, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
736ef8e 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Oct 28, 2022
@csviri @metacosm
refactor: improve bulk dependent resource api (#1525)
55c8014 
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <metacosm@gmail.com>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <metacosm@gmail.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri added a commit that referenced this pull request Oct 31, 2022
@csviri @metacosm
refactor: simplify handling of reused event sources (#1518)
b097fda 

Co-authored-by: Chris Laprun <metacosm@gmail.com>
csviri added a commit that referenced this pull request Oct 31, 2022
@csviri @metacosm
refactor: improve bulk dependent resource api (#1525)
6c4fefb 
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <metacosm@gmail.com>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <metacosm@gmail.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm