bulk dependent resources #1448
Merged
bulk dependent resources #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
changed the base branch from
next
to
decouple-event-source-from-cache
csviri
force-pushed
the
decouple-event-source-from-cache
branch
from
01f6512 to
c617cc0
Compare
csviri
force-pushed
the
bulk-dependent-resources
branch
from
4427cdf to
280c7ef
Compare
csviri
changed the base branch from
decouple-event-source-from-cache
to
next
csviri
force-pushed
the
bulk-dependent-resources
branch
2 times, most recently
from
c464c7f to
a833710
Compare
csviri
force-pushed
the
bulk-dependent-resources
branch
from
90321fa to
1240458
Compare
csviri
force-pushed
the
bulk-dependent-resources
branch
from
1240458 to
3d07b2e
Compare
csviri
commented
Sep 29, 2022
| private final List<ResourceDiscriminator<R, P>> resourceDiscriminator = new ArrayList<>(1); | ||
| private final BulkDependentResource<R, P> bulkDependentResource; | ||
| private ResourceDiscriminator<R, P> resourceDiscriminator; | ||
| private int currentCount; |
There was a problem hiding this comment.
Hmm, now just thinking this is singleton, we should not have global vars here, like the count
metacosm
force-pushed
the
bulk-dependent-resources
branch
from
06c5142 to
1d303a0
Compare
…erface" This reverts commit e2e6b18.
* feat: make it clearer when the CRD file isn't found * fix: only apply CRD when there is a CRD to apply
|
Kudos, SonarCloud Quality Gate passed! |
csviri
added a commit
that referenced
this pull request
Oct 3, 2022
csviri
added a commit
that referenced
this pull request
Oct 4, 2022
csviri
added a commit
that referenced
this pull request
Oct 4, 2022
csviri
added a commit
that referenced
this pull request
Oct 6, 2022
csviri
added a commit
that referenced
this pull request
Oct 6, 2022
metacosm
added a commit
that referenced
this pull request
Oct 7, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 19, 2022
csviri
added a commit
that referenced
this pull request
Oct 19, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 21, 2022
csviri
added a commit
that referenced
this pull request
Oct 21, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 25, 2022
csviri
added a commit
that referenced
this pull request
Oct 25, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
* feat: decouple event source from cache + list discriminator (#1378) * feat: bulk dependent resources (#1448) * feat: optional eventsource on dependent resources (#1479) * refactor: simplify handling of reused event sources (#1518) Co-authored-by: Chris Laprun <metacosm@gmail.com> * refactor: isolate index handling to BulkDependentResource interface (#1517) * feat: key based bulk resource creation (#1521) * improvement: bulk dependent resource api * merge Co-authored-by: Chris Laprun <metacosm@gmail.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index based bulk dependent resource creation Prototype in AbstractDependentResource.
Docs will be added as a separate PR
Depends on: #1378