-
Notifications
You must be signed in to change notification settings - Fork 439
Use the auto-tagging feature for e.g. processors #405
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Labels
Comments
@daften That's indeed would be great to fix. Could you work on a PR? |
What is the status of this? I use Symony's autowiring/autoconfigure feature a lot, and for the processors this cloud be a great improvement. I can definetely work on a PR for this. |
A PR is very welcome |
Cool, I'll work in one. Where is the bundle repo though? Because the one on Github says "Read Only". |
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
ASKozienko
pushed a commit
that referenced
this issue
Nov 2, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes #409 and #405. Also, keeps in mind #410. That's why services are public until a better solution is implemented.
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Similar to how twig does it: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php#L154
This line in the load function of EnqueueExtension.php should do it, but this is just one example:
It'd seem like a convenience for symfony4, with autowiring and autoconfigure.
The text was updated successfully, but these errors were encountered: