Skip to content

Use the auto-tagging feature for e.g. processors #405

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
daften opened this issue Mar 14, 2018 · 5 comments
Closed

Use the auto-tagging feature for e.g. processors #405

daften opened this issue Mar 14, 2018 · 5 comments

Comments

@daften
Copy link

daften commented Mar 14, 2018

Similar to how twig does it: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php#L154

This line in the load function of EnqueueExtension.php should do it, but this is just one example:

$container->registerForAutoconfiguration(\PsrProcessor::class)->addTag('enqueue.client.processor');

It'd seem like a convenience for symfony4, with autowiring and autoconfigure.

@makasim
Copy link
Member

makasim commented Mar 15, 2018

@daften That's indeed would be great to fix. Could you work on a PR?

@mnavarrocarter
Copy link
Contributor

What is the status of this? I use Symony's autowiring/autoconfigure feature a lot, and for the processors this cloud be a great improvement. I can definetely work on a PR for this.

@makasim
Copy link
Member

makasim commented May 30, 2018

A PR is very welcome

@mnavarrocarter
Copy link
Contributor

Cool, I'll work in one. Where is the bundle repo though? Because the one on Github says "Read Only".

@mnavarrocarter
Copy link
Contributor

Done! php-enqueue/enqueue-bundle#3

mnavarrocarter pushed a commit to mnavarrocarter/enqueue-dev that referenced this issue Jun 7, 2018
…or TopicSubscriberInterface

This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly
create their processors without worrying registering them as a service and adding the tag.

This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution
is implemented.
mnavarrocarter pushed a commit to mnavarrocarter/enqueue-dev that referenced this issue Jun 7, 2018
…or TopicSubscriberInterface

This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly
create their processors without worrying registering them as a service and adding the tag.

This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution
is implemented.
mnavarrocarter pushed a commit to mnavarrocarter/enqueue-dev that referenced this issue Jun 7, 2018
…or TopicSubscriberInterface

This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly
create their processors without worrying registering them as a service and adding the tag.

This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution
is implemented.
mnavarrocarter pushed a commit to mnavarrocarter/enqueue-dev that referenced this issue Jun 7, 2018
…or TopicSubscriberInterface

This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly
create their processors without worrying registering them as a service and adding the tag.

This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution
is implemented.
@makasim makasim closed this as completed Aug 4, 2018
ASKozienko pushed a commit that referenced this issue Nov 2, 2018
…or TopicSubscriberInterface

This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly
create their processors without worrying registering them as a service and adding the tag.

This closes #409 and #405. Also, keeps in mind #410. That's why services are public until a better solution
is implemented.
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants