[Bundle] Enqueue\Symfony\Client\ContainerAwareProcessorRegistry expects processors to be public #410
Labels
Milestone
Comments
|
A PR that fixes it would be great |
|
We should probably fix this first, then #409 since that one will make services private by default. |
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
mnavarrocarter
pushed a commit
to mnavarrocarter/enqueue-dev
that referenced
this issue
Jun 7, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes php-enqueue#409 and php-enqueue#405. Also, keeps in mind php-enqueue#410. That's why services are public until a better solution is implemented.
ASKozienko
pushed a commit
that referenced
this issue
Nov 2, 2018
…or TopicSubscriberInterface This will allow to symfony users that have autowiring/autoconfigure enabled to be able to rapidly create their processors without worrying registering them as a service and adding the tag. This closes #409 and #405. Also, keeps in mind #410. That's why services are public until a better solution is implemented.
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
With Symfony 4, all services are private by default. But
Enqueue\Symfony\Client\ContainerAwareProcessorRegistrykeeps them as a set of names which it tries toget()from the container.A better approach might be to inject tagged services or alternatively use a service locator.
The text was updated successfully, but these errors were encountered: